Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isPostalCode): add validation for Colombian postal code #2415

Merged
merged 1 commit into from
Jun 22, 2024
Merged

feat(isPostalCode): add validation for Colombian postal code #2415

merged 1 commit into from
Jun 22, 2024

Conversation

jorgevrgs
Copy link
Contributor

@jorgevrgs jorgevrgs commented Jun 5, 2024 •
edited
Loading

feat(isPostalCode): add validation for Colombian postal code

  • Updated isPostalCode by adding CO country code
  • Add valid and invalid tests

References:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@jorgevrgs jorgevrgs marked this pull request as ready for review June 5, 2024 20:43
rubiin
rubiin requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update readme

@jorgevrgs
feat(isPostalCode): add validation for Colombian postal code
ba6a508 
feat(isPostalCode): add more accurated regexp including state limits

fix(isPostalCode): update state codes

fix(isPostalCode): add missing trailling comma

docs(isPostalCode): add CO to the locale list
@rubiin rubiin requested a review from profnandaa June 6, 2024 16:37
@rubiin rubiin added the ✅ LGTM label Jun 6, 2024
@profnandaa profnandaa merged commit 6e2f084 into validatorjs:master Jun 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

Assignees
No one assigned
Labels
✅ LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgevrgs @profnandaa @rubiin